Holy Diver: Holy Diver - Input Handling Fix

Holy Diver seems not to handle button presses properly when two or more happen on the same frame. For example, simultaneous presses of A button and Right button make the character move but not jump, which often leads to falls into bottomless pits.

This patch fixes most of such issues, so any button press is handled regardless if another button was also pressed at the same time.

Holy Diver - Input Handling Fix

----------------------------------------------------------------
Usage
----------------------------------------------------------------

Apply the IPS file to the Japanese Holy Diver .nes ROM.

----------------------------------------------------------------
About
----------------------------------------------------------------

When two or more buttons are pressed on the same frame, the game
doesn't handle each press properly except the one checked last.
When the character stands or walks, the game checks if buttons
are pressed in the following order:

1. A button
2. B button
3. Down button
4. Left and Right buttons
5. Start button*
6. Select button*

* The last two seem not to influence.

When two buttons are pressed simultaneously, such an order creates
the following issues:

A + B the character attacks but not jumps
A + Down the character sits down but not jumps
A + Left the character moves left but not jumps
A + Right the character moves right but not jumps
B + Down the character sits down but not attacks
B + Left the character moves left but not attacks
B + Right the character moves right but not attacks
Down + Left the character moves one pixel left then sits down
Down + Right the character moves one pixel right then sits down

Fortunately, reversing the order of the first four checks fixes
most of the issues. So now:

A + B the character jumps but not attacks**
A + Down the character jumps then sits down
A + Left the character jumps and moves left
A + Right the character jumps and moves right
B + Down the character attacks and sits down
B + Left the character attacks and moves left
B + Right the character attacks and moves right
Down + Left the character sits down and turns left (not moves)
Down + Right the character sits down and turns right (not moves)

** Although this may still seem like an issue, it is not due to
the check order and occurs even if the buttons were pressed on
different frames within a short period of time.

----------------------------------------------------------------

Equidies, 2023


Database match: Holy Diver (Japan)
Database: No-Intro: Nintendo Entertainment System (v. 20210216-231042)
File SHA-1: 47B1A5A395604B8DC0196C74D62BCBF00A941F5F
File CRC32: C4CF0E8E
ROM SHA-1: BC6F5A884FD31FE6B4439E83AD6C2A29D038E545
ROM CRC32: BA51AC6F